hugo-theme-learn icon indicating copy to clipboard operation
hugo-theme-learn copied to clipboard

Published 20 hours ago • verified publisher icon matcornic

Fixing dangling <ul> when no pages or subsections are shown within the submenu

Open josemonsalve2 opened this issue 5 years ago • 3 comments

Hi,

I realized that when you only have hidden pages or subsections in your menu, the html tag

    will still be created with nothing inside. This causes a space to be added for submenus, but since they are hidden, nothing else is inside that space.

    Here is an image of what I mean.

    Screen Shot 2019-06-05 at 11 30 57 AM

    I have added a variable to check if all the pages or sections are hidden. if so, then it would not try to render a submenu.

    Let me know if this works.

josemonsalve2 avatar Jun 05 '19 16:06 josemonsalve2

Any chance you can consider this PR?

josemonsalve2 avatar Dec 09 '19 22:12 josemonsalve2

Should I close this PR? It has conflicts now and it has been over a year I submitted it.

josemonsalve2 avatar Nov 03 '20 02:11 josemonsalve2

Does this bug still exist? Then keep it, fix the conflicts (should not be too difficult) and mark matalo to check this PR.

mirisbowring avatar Nov 03 '20 07:11 mirisbowring