Mathieu Cornic
Mathieu Cornic
Hi @FGRibreau ! No plugin system planned yet :). Mjml is a framework, Hermes is not. Basically, Hermes is just Golang HTML templates describing typical emails ^^ (containing optional button,...
I think chart addition would be great ! Although, I think `Chart` struct should be more service-agnostic as possible, meaning it should contains points or something, not just params (it...
@FGRibreau I think this is the way to go 😉 Seeing the (big) swagger spec, I think that some fields don't need to be in the final struct. Just keep...
Ok Nice ! You may have to set struct properties as public for them to be available in the Go templating. (Just uppercase the first letter) I'm not sure private...
@FGRibreau So will I ;)
Hello :) Minifying would be nice indeed, and I agree that this should be an option. In your example `hermes.Config` is the same struct as `hermes.Hermes`. We could just add...
Go officially considers `tel` as unsafe. Only http, https and mailto are supported See discussions: - https://github.com/golang/go/issues/20586 And documentation: - https://go-review.googlesource.com/c/go/+/52853/3/src/html/template/url.go
Thanks @ruqqq for the PR. Looks fine to me for now, but could you add/modify some examples and tests ? The goal is checking automatically with CI that Markdown is...
@ruqqq Hmm, you're right. At first, when I created this issue, I thought I would make all fields Markdown enabled. But we need to see if themes are robust enough...
@jaybeecave Not supported but I think the use case is common and could be integrated. Do you want to make a PR ?