Mathieu Besançon

Results 257 comments of Mathieu Besançon

> If it turns out to be much better, then why keep the old format? this could be a longer-term goal. I agree that a bridge will be a first...

@blegat's design proposal seems to fit the needs of the PR and would result in less changes, I'll change things accordingly. The only awkward thing is that solvers will dispatch...

I'll let you appreciate the awfully cryptic error messages: ``` ERROR: LoadError: LoadError: cannot assign a value to variable Core.Integer from module MathOptInterface Stacktrace: [1] top-level scope at /home/mbesancon/julia_projects/MathOptInterface.jl/src/sets.jl:667 [2]...

Indeed yes, fixed it and added comments in last commits. I now how more expected failing tests

All the failures now are in Bridges, looking like follows: ```julia [1] top-level scope at /home/mbesancon/julia_projects/MathOptInterface.jl/test/Bridges/lazy_bridge_optimizer.jl:490 [2] top-level scope at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.5/Test/src/Test.jl:1115 [3] top-level scope at /home/mbesancon/julia_projects/MathOptInterface.jl/test/Bridges/lazy_bridge_optimizer.jl:483 [4] top-level scope at...

Using type printing for tests is not robust. Julia 1.6: ```julia julia> MOI.ScalarAffineFunction{Float64} MathOptInterface.GenericScalarAffineFunction{Float64, Vector{MathOptInterface.ScalarAffineTerm{Float64}}} ``` Julia 1.5: ```julia julia> MOI.ScalarAffineFunction{Float64} MathOptInterface.GenericScalarAffineFunction{Float64,Array{MathOptInterface.ScalarAffineTerm{Float64},1}} ``` The hacky path:tm: would be to override...

pinging @blegat, not sure what a good future-proof solution would be

the issue is that string interpolation with `$` replaces `MOI` with `MathOptInterface`

@odow some update when updating these lines, this was a pain because the alias printing behavior changed with julia 1.6, so we could accommodate the string tests to 1.6 or...

@blegat that's not helping our case if we don't want to export things and still keep the SAF alias correctly? In case getting this alias to work is troublesome, this...