matano icon indicating copy to clipboard operation
matano copied to clipboard
verified publisher icon matanolabs

fix: allows enable/disable of detections via config file

Open rileydakota opened this issue 2 years ago • 4 comments

Wanted to throw this out there to start a discussion on the implementation. I tested with:

  • a disabled detection
  • an enabled detection
  • both enabled and disabled detection

thoughts? Major thing IMO would be that it defaults to false if the key isn't specified, but I believe this is consistent with the docs.

Screenshot 2023-08-09 at 11 14 38 AM Screenshot 2023-08-09 at 11 15 40 AM

rileydakota avatar Aug 09 '23 15:08 rileydakota

I am also willing to move this logic to the infra code and just have the decision made to package a detection or not via the CDK. Just wanted to open a PR to start the discussion 😁

rileydakota avatar Aug 11 '23 00:08 rileydakota

@shaeqahmed @Samrose-Ahmed any chance we could kick off the CI job again, I am a bit confused on why the build failed

rileydakota avatar Aug 23 '23 20:08 rileydakota

Hey @rileydakota, looks like you might need to rebase since I recently committed a change to fix the broken CI build error you are getting

shaeqahmed avatar Aug 24 '23 03:08 shaeqahmed

@shaeqahmed looks like that did the trick! Would love some feedback on this when you get time :). Totally happy to refactor this to live in the CDK portion of the app versus runtime if that makes more sense

rileydakota avatar Aug 27 '23 00:08 rileydakota