Matan Lurey comments

Results 274 comments of


                                            Matan Lurey

Annotation for methods that can be overridden but not called

That sounds pretty complicated, and I'd worry about it being abused/confused with `@protected` (or having a bunch of methods that will show up in the public API, but not really...

Annotation for methods that can be overridden but not called

Ah OK, I understand now, thanks for explaining. This is a similar thing we'd like to lint for Angular Dart, definitely useful. /cc @ferhatb

Please allow us to mock the Client used by _withClient

Maybe I misunderstand something, but I'm on @nex3's side on this one. Imagine asking to mock `new DateTime()`. Clearly that isn't possible - we do have a new different package,...

Use DDC for JS compilation

@nex3: I imagine though you'd still want dart2js for the "binary", right? i.e. dart-sass.js (dart2js) and dart-sass.debug.js (using DDC)

Support running in a browser

I think just having the capability would be enough, for now. A sass_browser package could always implement the gritty bits.

Benchmarks: Record Dart VM time with JIT'd/warm code

I don't mind helping here! Internally and with Bazel we'd have it as a worker, so I can contribute. _Edit_: @nex3 Would you prefer a separate repository for Bazel rules...

Allow substituting type annotation for @Query(read: ...)

My intuition is to roll-out slowly, and only support unambiguous inference: ```dart @Component( directives: const [Child], template: ''' ''', ) class Comp { @view List child; } ``` In this...

Allow substituting type annotation for @Query(read: ...)

Exactly a `Child`. Keep it simple. We can always expand later. **EDIT**: Specifically, this should be sugar for basically saying: > Give me all instances of directive `Child` in my...

Allow substituting type annotation for @Query(read: ...)

@leonsenft: WDUT of my initial proposal? I might be able to tackle this!

Allow substituting type annotation for @Query(read: ...)

Note that we technically already support this for `List`, and soon `Element`: https://github.com/dart-lang/angular/issues/814 ... so it probably makes sense to generalize this soon.