Matan Lurey comments

Results 274 comments of


                                            Matan Lurey

Add a BuildFailure class, and catch in the runners

@jakemac53 any thoughts here?

Support deep linking in the dev server without hash location strategy

> Otherwise we should document how to get your own handler to do this. This is probably the easiest route for for now.

Support deep linking in the dev server without hash location strategy

Maybe we just need a way to write a "serve.dart", i.e. let `build_runner` take care of almost everything, but override the server handler?

Enforce `build_extensions` config from `build.yaml` to be accurate

+1. Definitely we should document that it's expected to be in sync, and we will enforce in future.

Enforce `build_extensions` config from `build.yaml` to be accurate

Does this overlap a bit with the work required for `transient` files for build_runner?

Enforce `build_extensions` config from `build.yaml` to be accurate

But the longer term goal still being to be consistent, right?

Enforce `build_extensions` config from `build.yaml` to be accurate

Are the restrictions considered cumbersome? I guess I don't understand _why not_.

Enforce `build_extensions` config from `build.yaml` to be accurate

Similar to https://github.com/dart-lang/build/issues/907, maybe we could support something like a `--strict-build-extensions` which guarantees additional compatibility with Bazel?

Add module size "lint"

I like this one! I'd also love more docs on what a module is, how it effects compilation time, etc. On Tue, Mar 6, 2018, 8:05 AM Kevin Moore wrote:...

All the things! Some ideas: * `--[no]-module-checks`: Enable/disable checking modules for potential problems. * `--module-check-deps`: If `--module-checks` is enabled, also check dependencies. Ideally we wouldn't be checking dependencies by default,...