Matan Lurey

I re-ran the tool @ HEAD filtering out failed commits with "Newer commit available": ```txt Summary: - Linux linux_license: 76/116 (0.66) - Linux mac_unopt: 34/116 (0.29) - Mac mac_host_engine: 32/116...

Thanks! Tweaked to ignore any failure that includes the string `(canceled)`. That does further lower to `Linux linux_web_engine: 7/116 (0.06)`, or 6%. 6% is 6x higher than the reported 1%...

Closing as something we'll likely not pursue.

@gaaclarke I am going to assume you're taking the lead on this, but let me know if you'd like to pair/chat it out.

Re-assigning to @jtmcdole to babysit.

I have some local patches that speed this up by between 5 and 20x, still twiddling a bit.

Same issue with map literals

The biggest problem is Dartfmt needs to receive a completely valid program (it uses the full AST parser) so it's not really possible to select arbitrary lines to format. You...

That problem really should be solved on their end - if they insist in bespoke formatting rules they should write a formatter. I was told that they have started accepting...

I have another reproduction case that doesn't seem _too_ crazy: ``` dart new LibraryBuilder() .addImport((i) => i.setUri('coffee_app.dart')) .addClass((c) => c .setName('Coffee\$Injector') .setImplements(['Coffee']) .addField((f) => f .setFinal() .setType((t) => t.setIdentifier('DripCoffeeModule')) .setName('_dripCoffeeModule'))...