ti-websocket-client icon indicating copy to clipboard operation
ti-websocket-client copied to clipboard

JSlint errors left

Open Hilko-Lantinga opened this issue 13 years ago • 0 comments

First of all, great work!!! I'm really looking forward to see this integrated with socket.io. I've seen that you've fixed some JSlint errors, I've found some more:

You're creating arrays like this: var words = new Array(size); JSlint recommends using array literal notation, and javascript doesn't need an array size, it will be incremented automatically.

So you could just do: var words = [];

Besides that there are some variable undefined (j, _base64_keyStr, str, reason) And some node.js/browser methods left that should be replaced with titanium methods (console.error, console.trace) And some comma's that should be remove (behind type: Ti.Codec.TYPE_BYTE)

Hilko-Lantinga avatar Nov 20 '11 12:11 Hilko-Lantinga