[BUG] Inconsistency of the title of the menu designed to open in web browser

[barijaona]

Is there an existing issue for this?

• [X] I have searched the existing issues

Current Behavior

in the Settings, there is an option called "Use default browser to open Links".

When it is disabled, links are opened in the internal browser. But the label in the sharing menu is wrong: it displays "Open in Safari".

Reversely, when the "Use default browser to open Links" setting is enabled, when you share a link, it launches Safari as expected. The label in the sharing menu is "Open in Browser". I guess it means "Open in Internal Browser".

Expected Behavior

When "Use default browser to open Links" is enabled, the title of the menu should be "Open in Safari" (or "Open in Chrome" if the default browser is Chrome, etc.)

When "Use default browser to open Links" is disabled, the title of the menu should be "Open in Browser" (or better: "Open in internal browser")

Steps To Reproduce

• In the in-app settings, make sure that "Use default browser to open Links" is disabled
• Select a toot or a profile
• Select "Share…" in the three-dots (...) menu
• You'll see an item to "Open in Safari" (in default iOS configuration)
• Select this: you will not be brought to Safari, but will remain in a web view internal to Mastodon.app

Environment

- Device: iPhone SE (2nd generation), iPhone 14 Pro Max
- OS: iOS 16.1.1
- Version: 1.4.8
- Build: 219

Anything else?

This is a reformulation of issue #738