[BUG] Mentions notifications never stop loading for empty mentions

[nedjulius]

Is there an existing issue for this?

• [X] I have searched the existing issues

Current Behavior

If user has no mentions and tries to refresh them, the view never stops showing a loader.

Expected Behavior

The loader should stop.

Steps To Reproduce

Before taking these steps to reproduce, make sure you do not have any mentions and are not going to receive any throughout the testing period.

1. Go to notifications page
2. Click on mentions tab
3. Pull to refresh page
4. Observe the infinite loader

Environment

- Device: iPhone Xs
- OS: iOS 15.6.1
- Version: v1.4.5
- Build: 144

Anything else?

Link to a similar issue that was raised back in March: https://github.com/mastodon/mastodon-ios/issues/337

[Yonodactyl]

Wish we could take this a step further too: Empty States!

It would be nice to see a set of labels and a nice image to let the user know "it looks like nothing is available here."

[nedjulius]

Wish we could take this a step further too: Empty States!

It would be nice to see a set of labels and a nice image to let the user know "it looks like nothing is available here."

I agree. I think having an empty state screen would improve UX a lot. When I saw the empty mentions for the first time, my intuition suggested that it was a bugged view.