mastodon-ios icon indicating copy to clipboard operation
mastodon-ios copied to clipboard

[BUG] Color profile stripped when image is uploaded

Open heyimandreas opened this issue 2 years ago • 1 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Current Behavior

When uploading an image from your iPhone taken with the phone camera the image uploaded to Mastodon is stripped of its color profile. This makes the image seem bland or different from how the image is intended to look.

Expected Behavior

The uploaded image should look exactly like and have the same color profile/space as the image in your phone.

Steps To Reproduce

  1. Take a picture
  2. Upload it to Mastodon through the app
  3. Notice how the color profile/space is different from the original image

Environment

- Device: iPhone 12 Pro
- OS: 15.4.1
- Version: 1.4.0
- Build: 121

Anything else?

No response

heyimandreas avatar May 13 '22 14:05 heyimandreas

Issue confirmed. Thank you for your feedback.

https://github.com/mastodon/mastodon-ios/commit/16365d5d094f2a4bab91f9cb04dce8eff4b0b818#diff-ea777b703cbeed2ae5b14ce96e803d611323277c4ced44f849b29875cdf2cbdaR92-R94 There is a patch add the color space and profile to compressed image but the server still ignore it. Maybe the server trim the profile on the remote too. @Gargron

I test it with iPhone's shot.

  1. Take a photo. It's in RBG color space with Display P3 ICC profile
  2. Upload to server in mastodon.online web client
  3. Download the uploaded photo
  4. The photo's ICC profile is sRGB IEC61966-2.1

MainasuK avatar May 24 '22 08:05 MainasuK