dynamic-cdn-webpack-plugin icon indicating copy to clipboard operation
dynamic-cdn-webpack-plugin copied to clipboard

Support for webpack 5

Open kmalakoff opened this issue 3 years ago • 10 comments

I was using this plugin for webpack 4 and wanted to use it for webpack 5.

If you are interested in accepting with pull request, there are a few points of note:

  • I republished it under @effortlessmotion/dynamic-cdn-webpack-plugin so we'd need to change the module name back
  • I added a line to the README.md warning this is a fork when I published it under a different org
  • I made it work with Node 10 like webpack guarantees as a compatible version
  • I removed ava and replaced it with tape as I couldn't get the latest ava to test on Node 10
  • I removed babel and es6 modules to make this simpler to test, run, and publish without extra steps. Webpack 5 uses require for backwards compatibility without transpiling

kmalakoff avatar Jul 04 '21 03:07 kmalakoff

@kmalakoff can you please link this to say it fixes #70?

ChocolateLoverRaj avatar Jul 10 '21 20:07 ChocolateLoverRaj

This fixes issue 70

kmalakoff avatar Jul 11 '21 00:07 kmalakoff

@mastilver are you still updating this?

mg-83 avatar Jul 15 '21 11:07 mg-83

Hi @kmalakoff ! One of the maintainers here :)

Thanks for the huge help in adding Webpack 5 support to this plugin. Much appreciated.

I'm unable to reach @mastilver (I'll try again) so I'm unsure as to how we would publish to npm but I don't think that should stop us from merging this into the codebase.

I'll go through your PR and get back on this asap. If in the event we aren't able to push this to npm, I think we can add a message to the README pointing to the @effortlessmotion/dynamic-cdn-webpack-plugin for now.

aulisius avatar Jul 29 '21 16:07 aulisius

Hi @aulisius, any updates?

richardantao avatar Oct 05 '21 18:10 richardantao

Hi @richardantao, you can use @effortlessmotion/dynamic-cdn-webpack-plugin package which supports webpack 5.

aulisius avatar Oct 06 '21 05:10 aulisius

FYI we have never been able after multiple attempts to contribute back to this module with module-to-cdn. We have decided to fork it under Talend github organisation. The fork is public and we have deployed sites in production with custom CDN based on this fork. https://github.com/Talend/ui/tree/master/fork

We have added multiple features to answer needs for deployments:

  • possibility to have other CDN than unpkg which is not for production cie website.
  • cdn url formating
  • add metadata to html webpack plugin
  • fix bug around dependencies management
  • introduce a dependencies.json file along UMDs

We plan to add webpack 5 support this year

jmfrancois avatar Apr 21 '22 07:04 jmfrancois

Would be great to have this done. I'm sure the maintainers could update the pull request and fix the issues directly, no? Can anyone else help speed this up?

cosmincc avatar Jun 11 '22 09:06 cosmincc

There's no blockers to merge this PR but only @mastilver holds the access to publish on npm. So, even if the PR is merged, it wouldn't be updated on npm

aulisius avatar Jun 12 '22 10:06 aulisius

@mastilver would be grateful if you can publish it. thank you.

Nishchit14 avatar Oct 12 '22 09:10 Nishchit14

author is dead or what? this project is saddly no longer maintained as i see.

CSDev0 avatar Jun 12 '23 23:06 CSDev0