winrm icon indicating copy to clipboard operation
winrm copied to clipboard

Published 20 hours ago • verified publisher icon masterzen

public interfaces for client credentials and endpoint URL

Open dpotapov opened this issue 6 years ago • 2 comments

Hi,

I've created two authentication modules for NTLM and KRB5. They can be implemented a bit better if there would be following properties publicly available:

  • endpoint.url()
  • client.username
  • client.password

Thanks.

dpotapov avatar Jun 06 '18 07:06 dpotapov

Hi @dpotapov ,

Indeed this is probably easy to do, and would help other people implement authentication modules.

I'm wondering, though, if you would want to contribute your NTLM and KRB5 projects as PRs to this project? That would solve your issue and we could DRY a bit the codebase to put in common the Post method of all the transports implementations. One downside would be that this new code would require some automated tests (I have no idea how feasible this is).

masterzen avatar Jun 06 '18 08:06 masterzen

Not sure if I could accommodate some time for making PRs in the near future, though I'm definitely willing to contribute at some point.

dpotapov avatar Jun 06 '18 16:06 dpotapov