winrm icon indicating copy to clipboard operation
winrm copied to clipboard

Test hangs for /winrm

Open cbednarski opened this issue 10 years ago • 1 comments

When running make test there's a relatively high chance that the tests for github.com/masterzen/winrm/winrm will hang. We see this manifest as intermittent CI failures in packer .

I suspect there's a race condition in the test code, possibly related to gopkg.in/check.v1. gotip's race detector identifies a ton of things but there was a bit too much noise for me to narrow it down.

Here's a run I aborted at around 90 seconds.

➜  winrm git:(master) make test
==> Installing dependencies
==> Testing Packer...
go test ./...
?       github.com/masterzen/winrm  [no test files]
ok      github.com/masterzen/winrm/soap 0.005s
^Cexit status 2
FAIL    github.com/masterzen/winrm/winrm    95.663s
make: *** [test] Error 1

When it passes it takes basically no time at all.

➜  winrm git:(master) make test
==> Installing dependencies
==> Testing Packer...
go test ./...
?       github.com/masterzen/winrm  [no test files]
ok      github.com/masterzen/winrm/soap 0.005s
ok      github.com/masterzen/winrm/winrm    0.022s

cbednarski avatar Jun 29 '15 22:06 cbednarski

I think we solved this around July 2015, feel free to reopen if you still see the problem.

masterzen avatar May 16 '16 16:05 masterzen