Brice Figureau
Brice Figureau
Integrations test failures for ovh, because of double encoded quoted strings like: ``` === RUN TestDNSProviders/dnscontroltest.ovh/16:TXTMulti-same:Create_TXTMulti_1 integration_test.go:220: CREATE TXT foo.dnscontroltest.ovh "simple" ttl=300 integration_test.go:220: REFRESH zone dnscontroltest.ovh integration_test.go:239: Expected 0 corrections...
> Integrations test failures for ovh, because of double encoded quoted strings like: > [snipped] > > I'm going to test with your suggested changes. So, with OVH using `SetTargetTXTfromRFC1035Quoted`...
I've fixed OVH with this change: ```patch diff --git i/providers/ovh/ovhProvider.go w/providers/ovh/ovhProvider.go index e6e91325..c6771d9f 100644 --- i/providers/ovh/ovhProvider.go +++ w/providers/ovh/ovhProvider.go @@ -190,7 +190,16 @@ func nativeToRecord(r *Record, origin string) (*models.RecordConfig, error) {...
> Folks, Just to let you know... I think I may not be explaining this all correctly. I don't want to send you down the wrong road. > > [snip]...
> > Based on the premise we need to be able to modify records entered by the UI, I need to unquote in `nativetoRc` with something along of `models.ParseQuotedFields` (even...
I'm able to fix the tests with the following patch: ```patch @@ -190,7 +193,18 @@ func nativeToRecord(r *Record, origin string) (*models.RecordConfig, error) { } rec.SetLabel(r.SubDomain, origin) - if err :=...
As said in my previous comment, I've produced an implementation that seems correct to me in #1582. Let me know if there's anything that needs to be done.
I'm wondering if this would be fixed by the new TXT handling of #1567? Basically it seems the string is split somehow and that creates issues with imbalanced quotes later...
I'll try to do a bit of tests over the week-end, as I remember that long DKIM records used to work with previous dnscontrol version in the past.
We just got this issue, it's coming from the fact that the module automatically converts to integers all strings looking as an integer (see `fixnumify`). I think @garethr original idea...