react-native-action-button icon indicating copy to clipboard operation
react-native-action-button copied to clipboard

Move data fetching code or side effects to componentDidUpdate.

Open bernardnongpoh opened this issue 4 years ago • 5 comments

Warning in the console: componentWillReceiveProps has been renamed and is not recommended for use. See https://fb.me/react-async-component-lifecycle-hooks for details.

  • Move data fetching code or side effects to componentDidUpdate.

bernardnongpoh avatar May 14 '20 04:05 bernardnongpoh

Yeah... Looks like it was fixed 4 months ago but never released? If you look in the ActionButton.js, you can see that the code has been updated to useEffect, but if you look at the installed version in node_modules the "componentWillReceiveProps" is still there.

Hopefully someone notices eventually.

yerba-mate avatar May 18 '20 00:05 yerba-mate

There hasn't been a release since 2018??

  • https://www.npmjs.com/package/react-native-action-button
  • https://github.com/mastermoo/react-native-action-button/releases

Are people just cloning and using this code directly in their own projects?

gregfenton avatar Jun 18 '20 22:06 gregfenton

Can someone tell me how to fix this? Is there a fixed version of ActionButton.js somewhere?

ytr0 avatar Jun 29 '20 19:06 ytr0

So yeah the only way I "fixed" the problem was to clone the existing code, which contains the fix, and use it as a component. There is someone out there doing the pull-requests/fixes but no one doing the builds.

yerba-mate avatar Jun 30 '20 00:06 yerba-mate

Ah, now I see. Thank you. I hope the maintainer is still alive.

ytr0 avatar Jun 30 '20 00:06 ytr0