react-native-action-button icon indicating copy to clipboard operation
react-native-action-button copied to clipboard

Published 20 hours ago • verified publisher icon mastermoo

Fix native feedback radius

Open renzo-blockchain opened this issue 6 years ago • 2 comments

When setting fixNativeFeedbackRadius to true and giving the ActionButton position 'Center'. The AtionButton and ActionButtonItems would have an offset from the center due to incorrect styling.

fixNativeFeedbackRadius also caused an ugly shadow on ActionButtonItems and their respective lable, and also a cropped dropshadow.

For the ActionButtonItem, this was due to the shadow styling was set on the wrong element for android. As for the lable, we do not need to set the fixNativeFeedbackRadius to the touchableBackground (the lable is rectangular anyway). You'll notice that the ripple effect on the lable would extend in a circular fashion outside the borders of the lable.

renzo-blockchain avatar Jan 10 '19 21:01 renzo-blockchain

Any news on this PR? Thanks!

davux avatar Feb 18 '19 20:02 davux

Any news on this? It would be awesome if this could get merged!

FelixDQ avatar Jul 29 '19 13:07 FelixDQ