Daniel Arndt
Daniel Arndt
Follow-up to https://github.com/kokkos/kokkos/pull/5188 addressing https://github.com/kokkos/kokkos/pull/5188#issuecomment-1179206669.
Apparently, HBWSpace is not tested in our current CI and (therefore unsurprisingly) broken.
In some cases, selecting a custom workgroup size gives significantly better performance than relying on the compiler to choose.
Based on top of #4843.
`Policy` is not trivially copyable so we need to use the `std::reference_wrapper` workaround for that as well.
Alternative to #727 making sure that `reduction_identity` is actually used.
We don't use `Kokkos::Sum` anywhere, so the specialization for `reduction_identity` should never be called. If we care about backward compatibility, we could deprecate instead of course.
Fixes #165. This is currently in a pretty rough shape and in particular doesn't compile for any kDOP. Some unit tests also still fail and we are likely missing adding...
That's the only warnings we were seeing in the logs even if it didn't get caught properly in our CI.