Daniel Arndt

Results 1005 comments of Daniel Arndt

There are tons of failing tests ``` The following tests FAILED: 1 - Kokkos_CoreUnitTest_Serial_ViewSupport (Subprocess aborted) Kokkos 2 - Kokkos_CoreUnitTest_Serial1 (Subprocess aborted) Kokkos 3 - Kokkos_CoreUnitTest_Serial2 (Subprocess aborted) Kokkos 4...

We generate `builddir/cmake_packages/Kokkos/KokkosConfig.cmake` for compatibility with `Trilinos` and haven't run into any issues with other codes with that.

@greole Can you confirm that you are running into this problem with a recent `Kokkos` version?

For SYCL, on a Intel GPU Mac 1550, I'm seeing ``` Deep Copy: 18.826000 Parallel For: 28.742000 Manual Unroll: 75.764000 Pragma unroll: 77.301000 ```

> I am interested in the algorithms section of Kokkos and I feel like taking a look. I am wondering why sort and random are left out? I was going...

What do others do: https://github.com/dealii/dealii: - creates for every external dependency (including the C++ Standard Library) a module partition explicitly by listing all used symbols - for every internal header...

The last commit https://github.com/kokkos/kokkos/pull/8132/commits/c0221768c7bfde6ea5d94c049b22db79a31d6221 provides an alternative to modifying the test files directly by copying them to the build directory and then replacing includes with imports for headers that have...

> I have concerns about the test headers that have to be duplicated and modified by CMake. I think this may be avoided. I presented to approaches and prefer the...

> Just a minor comment, still need to do a full review, but why `ccm` as the extension? We use `.cpp` for C++ files, it would make more sense to...

The test failures are spurious/unrelated.