tf2-patches icon indicating copy to clipboard operation
tf2-patches copied to clipboard

damaged mini sentries do not have red icon to alert the engineer that it needs to be repaired

Open ghost opened this issue 5 years ago • 5 comments

Description

exactly what the title says, probably a minor detail valve devs forgot to add when they made minis repairable

Checklist

  • [x] None of the open or closed issues document this problem.
  • [x] This is a bug, not a new idea.
  • [x] This is objectively a bug, and not something that people commonly disagree on.
  • [x] This issue occurs on the latest Team Comtress release, or the master branch.
  • [x] This issue occurs on the latest vanilla TF2 update.
  • [x] This bug is in the code of the game, not in the textures, sounds, or other resources.
  • [ ] This issue is listed on the Source 1 official bugtracker.
  • [ ] This issue occurs with DirectX level 100.
  • [x] This issue occurs when using no custom content.
  • [ ] This issue occurs when using start_tf2.bat (or start_server.bat) with no custom launch options.
  • [x] This issue occurs when using a listen server (using the map command ingame).
  • [x] This issue occurs when using a dedicated server.
  • [ ] This bug is in the internal procedures or tooling (e.g. the build process).

Reproduction

  1. build minisentry 2.have someone to damage it 3.you will hear a noise to alert you that your sentry has been damaged but no red repair icon seen

Screenshots

20201112105129_1

ghost avatar Nov 12 '20 08:11 ghost

This is intentional

		// do not show low health for mini-sentry
	case BUILDING_HUD_ALERT_LOW_HEALTH:
	case BUILDING_HUD_ALERT_VERY_LOW_HEALTH:
		bShowAlertTray = pObj->IsMiniBuilding() == false;
		m_pWrenchIcon->SetVisible( bAlertTrayFullyDeployed && bShowAlertTray );
		break;

Found in game\client\tf\tf_hud_building_status.cpp

horiuchii avatar Nov 12 '20 09:11 horiuchii

@RealHoriuchi that was because when the gunslinger was first added it couldn't repair mini sentries,it could only refill their ammo. this is why if you empty a mini's ammo you get the notification.

edit: basically valve forgot to remove that piece of code after gun mettle edit 2: grammar

ghost avatar Nov 12 '20 09:11 ghost

Although minor, definitely wouldn't hurt to alter this.

AzureWoof avatar Nov 12 '20 17:11 AzureWoof

I would argue that this is still a feature, not a bug mainly due to the disposable nature of mini-sentries, particularly that they are meant to be spammed (ie. destroyed and rebuilt). Repairing minisentries is not that common and having the indicators in those kinds of situations would get spammy/annoying very quickly.

You could just make it a setting to toggle the old behavior but that seems like more effort than it's worth.

itVictor avatar Nov 13 '20 02:11 itVictor

I would argue that this is still a feature, not a bug mainly due to the disposable nature of mini-sentries, particularly that they are meant to be spammed (ie. destroyed and rebuilt). Repairing minisentries is not that common and having the indicators in those kinds of situations would get spammy/annoying very quickly.

You could just make it a setting to toggle the old behavior but that seems like more effort than it's worth.

The indicator is there, just bugged (at least for me)

MeDerpWasTaken avatar Nov 13 '20 02:11 MeDerpWasTaken