[mvm] remove the heal on kill and damage upgrades for rocket and sticky jumper and rocket specialist upgrade for rocket jumper

[ghost]

Description

those upgrades are clearly useless, damage upgrades have no effect on weapons which already deal no damage, health on kill is obvious, you gotta kill to get the health. the rocket specialist upgrade for rocket launchers is to deal maximum damage upon direct impact(no damage falloff) and to stunn robots for a small ammount of time. the rocket jumper is more of an utility tool so that you get from a certain part of the map to another, so it shouldn't be aimed towards robots, making this upgrade kind of questionable(rockets still stunn). also, this will prevent new players from trying to use those as normal weapons, at least in mvm and should be making them learn faster that these weapons deal ZERO damage to both the player and the bots

Checklist

• [x] None of the open or closed issues document this idea.
• [x] This is a new idea, not a bug.
• [x] This idea does not seriously affect game balance.
• [x] This is obviously an improvement, not something that people commonly disagree on.
• [x] This is not an idea for new game content (e.g. new weapons, maps, sounds).

• [x] This idea is for the code of the game, not for textures, sounds, or other resources.
• [ ] This idea has been implemented in vanilla TF2.
• [ ] There is proof that this idea is well liked (e.g. a history of use of a similar mod in a competitive league).
• [ ] This idea has been implemented in a mod.
• [ ] This feature has existed in the vanilla game but was removed.
• [ ] This idea is for internal procedures or tooling (e.g. improving the build process, supporting new systems).

Screenshots

Alternatives

[TrickyTrix935]

In my opinion removing Rocket Specialist from the Rocket Jumper would classify more as a balance change, as it does have an effect (being able to stun robots). As for removing the damage and health on kill upgrades that should just be a case of changing a few lines in "\game\shared\tf\tf_gamerules.cpp" to the following:

first change: line 21167 to the following

			if ( bHideDmgUpgrades || iWeaponID == TF_WEAPON_ROCKETLAUNCHER && !pPlayer->IsAllowedToPickUpFlag() || iWeaponID == TF_WEAPON_PIPEBOMBLAUNCHER && !pPlayer->IsAllowedToPickUpFlag() )

second change: add this block between lines 21235 and 21236

	case 180:	// "heal on kill"
		{
			if ( iWeaponID == TF_WEAPON_ROCKETLAUNCHER && !pPlayer->IsAllowedToPickUpFlag() || iWeaponID == TF_WEAPON_PIPEBOMBLAUNCHER && !pPlayer->IsAllowedToPickUpFlag() )
			{
				return false;
			}
		}
		break;

Bear in mind this is purely theory as I am currently unable test it myself.

[rcmaehl]

No no, leave it in to piss off the tacobot.tf guys