mp_friendlyfire 1 issues

[Margen67]

Taunt kill names are from here: https://wiki.teamfortress.com/wiki/Taunts#Taunt_kills

TF2 wasn't developed with friendly fire in mind, so it doesn't work in most cases. This includes, but is not limited to:

• Scout:
  • Primary:
    • Shortstop:
      • Can't push teammates with alt-fire.
        Relevant code (click to expand)

        https://github.com/mastercomfig/team-comtress-2/blob/213be2ea75a491fc44aae03b96e3d142730ca38d/game/shared/tf/tf_weapon_pistol.cpp#L128-L129 https://github.com/mastercomfig/team-comtress-2/blob/213be2ea75a491fc44aae03b96e3d142730ca38d/game/shared/tf/tf_weapon_pistol.cpp#L141-L142
  • Secondary:
    • Mad/Mutated Milk:
      • Doesn't affect teammates.
        Relevant code (click to expand)

        https://github.com/mastercomfig/team-comtress-2/blob/213be2ea75a491fc44aae03b96e3d142730ca38d/game/shared/tf/tf_weapon_jar.cpp#L354-L355 https://github.com/mastercomfig/team-comtress-2/blob/213be2ea75a491fc44aae03b96e3d142730ca38d/game/shared/tf/tf_weapon_jar.cpp#L514-L515 Apply breadmonster model: https://github.com/mastercomfig/team-comtress-2/blob/213be2ea75a491fc44aae03b96e3d142730ca38d/game/shared/tf/tf_weapon_jar.cpp#L576 idk: https://github.com/mastercomfig/team-comtress-2/blob/213be2ea75a491fc44aae03b96e3d142730ca38d/game/shared/tf/tf_weapon_jar.cpp#L718
    • Flying Guillotine:
      • Doesn't affect teammates.
        Relevant code (click to expand)

        https://github.com/mastercomfig/team-comtress-2/blob/213be2ea75a491fc44aae03b96e3d142730ca38d/game/shared/tf/tf_weapon_jar.cpp#L1012-L1013
  • Melee:
    • Sandman, Wrap Assassin:
      • Projectiles don't affect teammates.
        Relevant code (click to expand)

        https://github.com/mastercomfig/team-comtress-2/blob/213be2ea75a491fc44aae03b96e3d142730ca38d/game/shared/tf/tf_weapon_bat.cpp#L882-L886 https://github.com/mastercomfig/team-comtress-2/blob/213be2ea75a491fc44aae03b96e3d142730ca38d/game/shared/tf/tf_weapon_bat.cpp#L1240-L1244
    • Sandman, Atomizer:
      • Taunt kill (Home Run) doesn't affect teammates.
        Relevant code (click to expand)

        https://github.com/mastercomfig/team-comtress-2/blob/213be2ea75a491fc44aae03b96e3d142730ca38d/game/server/tf/tf_player.cpp#L17876
• Soldier:
  • Primary:
    • All:
      • Projectiles don't collide with nearby teammates.
  • Secondary:
    • Mantreads:
      • Can't collide with teammates.
        Relevant code (click to expand)

        https://github.com/mastercomfig/team-comtress-2/blob/213be2ea75a491fc44aae03b96e3d142730ca38d/game/server/tf/tf_player.cpp#L8710-L8712
    • Righteous Bison:
      • Projectiles don't collide with teammates.
        Relevant code (click to expand)

        https://github.com/mastercomfig/team-comtress-2/blob/213be2ea75a491fc44aae03b96e3d142730ca38d/game/shared/tf/tf_projectile_energy_ring.cpp#L310-L311
• Pyro:
  • Primary:
    • All:
      • Doesn't affect teammates.
      • Can't deflect teammate's projectiles.
        Relevant code (click to expand)

        https://github.com/mastercomfig/team-comtress-2/blob/213be2ea75a491fc44aae03b96e3d142730ca38d/game/shared/tf/tf_weapon_flamethrower.cpp#L1264-L1266
    • Rainblower:
      • Taunt kill (Armageddon) doesn't affect teammates.
        Relevant code (click to expand)

        https://github.com/mastercomfig/team-comtress-2/blob/213be2ea75a491fc44aae03b96e3d142730ca38d/game/server/tf/tf_player.cpp#L17944-L17946
  • Secondary:
    • Flare Gun, Detonator, Scorch Shot:
      • Projectiles don't collide with nearby teammates.
        • This also affects Execution. (Scorch Shot's taunt kill)
• Demoman:
  • Primary:
    • Grenade Launcher, Loch 'n Load:
      • Projectiles don't collide with nearby teammates, and/or doesn't explode on contact with teammates.
        Relevant code (click to expand)

        https://github.com/mastercomfig/team-comtress-2/blob/213be2ea75a491fc44aae03b96e3d142730ca38d/game/shared/tf/tf_weapon_grenade_pipebomb.cpp#L784-L785 https://github.com/mastercomfig/team-comtress-2/blob/213be2ea75a491fc44aae03b96e3d142730ca38d/game/shared/tf/tf_weapon_grenade_pipebomb.cpp#L902-L903 https://github.com/mastercomfig/team-comtress-2/blob/213be2ea75a491fc44aae03b96e3d142730ca38d/game/shared/tf/tf_weapon_grenade_pipebomb.cpp#L994
  • Secondary:
    • Chargin' Targe, Splendid Screen, Tide Turner:
      • Doesn't collide with teammates.
  • Melee:
    • Ullapool Caber:
      • Doesn't explode on hitting teammates.
    • Eyelander, Horseless Headless Horsemann's Headtaker, Claidheamh Mor, Half-Zatoichi, Persian Persuader, Nessie's Nine Iron:
      • Taunt kill (Decapitation) doesn't affect teammates.
        Relevant code (click to expand)

        https://github.com/mastercomfig/team-comtress-2/blob/213be2ea75a491fc44aae03b96e3d142730ca38d/game/server/tf/tf_player.cpp#L18128
• Heavy:
  • Primary:
    • Huo-Long Heater:
      • Doesn't ignite teammates.
  • Melee:
    • Holiday Punch:
      • Crit/punching behind teammates does nothing.
        Relevant code (click to expand)

        https://github.com/mastercomfig/team-comtress-2/blob/213be2ea75a491fc44aae03b96e3d142730ca38d/game/shared/tf/tf_weaponbase_melee.cpp#L889
      • "Tickle" effect does nothing.
        Relevant code (click to expand)

        https://github.com/mastercomfig/team-comtress-2/blob/213be2ea75a491fc44aae03b96e3d142730ca38d/game/shared/tf/tf_weaponbase_melee.cpp#L908
    • Fists, Saxxy, Apoco-Fists, Holiday Punch:
      • Taunt kill (Showdown) doesn't affect teammates.
        Relevant code (click to expand)

        https://github.com/mastercomfig/team-comtress-2/blob/213be2ea75a491fc44aae03b96e3d142730ca38d/game/server/tf/tf_player.cpp#L17802
• Engineer:
  • Primary:
    • Frontier Justice:
      • Taunt kill (Dischord) doesn't affect teammates.
        Relevant code (click to expand)

        https://github.com/mastercomfig/team-comtress-2/blob/213be2ea75a491fc44aae03b96e3d142730ca38d/game/server/tf/tf_player.cpp#L18149
    • Rescue Ranger:
      • Doesn't affect teammates.
  • Secondary:
    • Short Circuit:
      • Secondary fire doesn't affect teammates.
  • Melee:
    • Gunslinger:
      • Taunt kill (Organ Grinder) doesn't affect teammates.
        Relevant code (click to expand)

        https://github.com/mastercomfig/team-comtress-2/blob/213be2ea75a491fc44aae03b96e3d142730ca38d/game/server/tf/tf_player.cpp#L17666
• Medic:
  • Primary:
    • Crusader's Crossbow:
      • Only heals teammates.
  • Melee:
    • Ubersaw:
      • Doesn't give uber for hurting teammates.
      • Taunt kill (Spinal Tap) doesn't affect teammates.
        Relevant code (click to expand)

        https://github.com/mastercomfig/team-comtress-2/blob/213be2ea75a491fc44aae03b96e3d142730ca38d/game/server/tf/tf_player.cpp#L18076
    • Vita-Saw:
      • Doesn't give organs for hurting teammates.
• Sniper:
  • Primary:
    • All except fully charged Machina headshots:
      • Doesn't affect teammates.
    • Huntsman/Fortified Compound:
      • Taunt kill (Skewer) doesn't affect teammates.
        Relevant code (click to expand)

        https://github.com/mastercomfig/team-comtress-2/blob/213be2ea75a491fc44aae03b96e3d142730ca38d/game/server/tf/tf_player.cpp#L17666
  • Secondary:
    • Jarate/Self-Aware Beauty Mark:
      • Same as Mad/Mutated Milk.
• Spy:
  • Melee:
    • All:
      • Can't backstab teammates.
        Relevant code (click to expand)

        https://github.com/mastercomfig/team-comtress-2/blob/213be2ea75a491fc44aae03b96e3d142730ca38d/game/shared/tf/tf_weapon_knife.cpp#L202 https://github.com/mastercomfig/team-comtress-2/blob/213be2ea75a491fc44aae03b96e3d142730ca38d/game/shared/tf/tf_weapon_knife.cpp#L617
• All classes:
  • Misc:
    • Spellbook:
      • Bleed/burn effects aren't applied.
  • Can't affect friendly buildings
  • Dominations don't show up on the scoreboard.

Checklist

• [x] None of the open or closed issues document this problem.
• [x] This is a bug, not a new idea.
• [ ] This is objectively a bug, and not something that people commonly disagree on.
• [x] This bug is in the code of the game, not in the textures, sounds, or other resources.
• [x] This issue occurs on the latest vanilla TF2 update.
• [ ] This issue is listed on the Source 1 official bugtracker.
• [x] This issue occurs with DirectX level 100.
• [x] This issue occurs on the latest Team Comtress release, or the master branch.
• [x] This issue occurs when using no custom content.
• [x] This issue occurs when using start_tf2.bat (or start_server.bat) with no custom launch options.
• [x] This issue occurs when using a listen server (using the map command ingame).
• [x] This issue occurs when using a dedicated server.
• [ ] This bug is in the internal procedures or tooling (e.g. the build process).

Reproduction

Read the description.

Screenshots

Setup Details

• Server or client:
• Operating system:
• Team Comtress version:
• Custom content:
• Launch options:
• Graphics driver:
• DirectX level:

Performance Details

• GPU model:
• CPU model:
• RAM amount:
• TF2 installed on:
• TC2 installed on:
• TC2 installation method:

[Margen67]

A lot of these are fixed by #276.