Av1an icon indicating copy to clipboard operation
Av1an copied to clipboard

Fix new svt-av1 versions 2.x.x being treated as old svt-av1

Open damian101 opened this issue 9 months ago • 3 comments

Invalid use of 1.. in a match function, as it has no upper bound. Replaced with a wildcard pattern to simply catch all remaining patterns, which I think should work fine here.

damian101 avatar May 10 '24 17:05 damian101

This is a little confusing. Matches are supposed to be exhaustive, so 1.. should be catching everything 1 and greater. What bug is occurring here? This should be a compile-time error if the match is not exhaustive.

shssoichiro avatar May 10 '24 23:05 shssoichiro

#837

trixoniisama avatar May 10 '24 23:05 trixoniisama

I see, however, I don't understand why this fixes the issue. As I mentioned, 1.. and _ should be equivalent here. If they're not, then that's a very unexpected behavior because the compiler should be throwing errors if we currently have a non-exhaustive match statement.

shssoichiro avatar May 11 '24 02:05 shssoichiro