Av1an icon indicating copy to clipboard operation
Av1an copied to clipboard

SVT-AV1-PSY --target-quality support?

Open NZDivinity opened this issue 9 months ago • 2 comments

Currently the --target-quality parameter for Av1an does not work with the PSY fork of SVT-AV1 - errors out. --target-quality does work when it is used in conjunction with --probe-slow.

The same Av1an command (without probe slow) works fine with regular SVT-AV1.

Any chance this parameter could be supported by SVT-AV1-PSY?

Edit : My bad, was a bit quick posting this issue. see Trix's reply below with context on possible cause.

NZDivinity avatar May 10 '24 10:05 NZDivinity

You could have given some additional context since we've started to troubleshoot it on the AV1 discord server...

It is likely that SVT-AV1-PSY is not recognized as modern SVT-AV1 and as such outdated parameters are fed to the encoder which leads to crashes.

The usefulness of keeping compatibility with incredibly old SVT-AV1 versions isn't evident to me. I think that to avoid further issues like this in the future, it would be better to remove support for these ancient versions. It will avoid false positives with potential forks and newer version numbers.

trixoniisama avatar May 10 '24 10:05 trixoniisama

Currently the --target-quality parameter for Av1an does not work with the PSY fork of SVT-AV1 - errors out.

SVT-AV1-PSY has been updated to current SVT-AV1 and is working just fine, so this issue can be closed.

gitoss avatar Jun 10 '24 11:06 gitoss

Unfortunately this issue is back as of SVT-AV1-PSY's recent (pre-release) update v2.2.0-rc1

Edit : ok.. working again as of v2.2.0.. I'm at a loss as to why, but I suspect it could do with compiling on my end. Closing for now as it seems to be sorted OR is a me issue :/

NZDivinity avatar Aug 18 '24 03:08 NZDivinity

This issue seems to stem from the set version tag in SVT-AV1-PSY's Cmakelists.txt. If someone runs into this issue while self compiling, just change the line set(VERSION_TAG "rc2") to set(VERSION_TAG ""). The release binaries seem to have already changed this.

Plamper avatar Sep 21 '24 07:09 Plamper