Av1an icon indicating copy to clipboard operation
Av1an copied to clipboard

Documentation: Add svt-av1 to the `--photon-noise` supported encoders

Open Littux-Dustux opened this issue 9 months ago • 5 comments

The documentation currently states that --photon-noise is only supported by aom and rav1e, when it works fine with svt-av1 (Tested using svt-av1-psy)

    --photon-noise <PHOTON_NOISE>
        Generates a photon noise table and applies it using grain synthesis [strength: 0-64]
        (disabled by default)

        [...]

        This option currently only supports aomenc and rav1e.

Littux-Dustux avatar May 08 '24 07:05 Littux-Dustux

That would be because mainline SVT-AV1 has only merged the photon-noise patch very recently, even though we've had access to it for more than a year in Soichiro's fork initially, then BlueSwordM's fork with some other patches and in SVT-AV1-PSY then. It should indeed be changed.

trixoniisama avatar May 08 '24 08:05 trixoniisama

The commit is for the fix-docs branch only - is av1an photon noise working for svt-av1 by now because it added --fgs-table?

gitoss avatar Jun 09 '24 08:06 gitoss

Looks like I forgot to update the docs when I merged in the patch to av1an to support photon noise in svt-av1. It is indeed working, only the documentation needs updated.

shssoichiro avatar Jun 09 '24 09:06 shssoichiro

Looks like I forgot to update the docs when I merged in the patch to av1an to support photon noise in svt-av1. It is indeed working, only the documentation needs updated.

Thanks for the clarification.

Speaking of docs, the photon noise implementation is still a bit black-box-ish :-) and I am wondering what enabling av1an's --photon-noise does to the encoders' DE-noise settings - i.e. REEMOVING noise (svt --film-grain-denoise / aom --enable-dnl-denoising & --denoise-noise-level).

The --help of svt is especially unhelpful because the description for --film-grain-denoise only refers to --film-grain, but doesn't mention --fgs-table

Concerning adding noise, the doc 'the two should not be used together" is clear that photon and non-photon are mutually exclusive.

gitoss avatar Jun 09 '24 12:06 gitoss

Photon noise does not enable any of the encoder's denoising. You're right, it may make sense to add that to the documentation as well.

shssoichiro avatar Jun 21 '24 14:06 shssoichiro