waveformSeekBar icon indicating copy to clipboard operation
waveformSeekBar copied to clipboard

Published 20 hours ago • verified publisher icon massoudss

New waveformTimeline view

Open mirco0 opened this issue 2 years ago • 2 comments

This pull request adds a new view waveformTimeline. This new view includes:

  • MediaPlayer
  • Timestamps
  • Audio area selector
  • Touch controls integrated with new

Todo list

  • [ ] Fix bugs relative to waveGap and waveWidth greater than minimal values

mirco0 avatar Jan 30 '23 23:01 mirco0

@mirco0 Hello! Thank you for your contribution to this project. I have checked your code and I'm not sure about MediaPlayer instance inside view. How it will work if the user populate list (recycler view) of waveforms? 🤔

Maybe it will be better to provide an API like attach or set player. In this case, the user can provide an external player. This approach seems more flexible IMHO

@massoudss

lincollincol avatar Feb 04 '23 09:02 lincollincol

@massoudss Hello! Thank you for telling me about the issue in my code. I think your solution is a good idea, I'll update and fix my code when possible

mirco0 avatar Feb 04 '23 10:02 mirco0