Squircle-CE icon indicating copy to clipboard operation
Squircle-CE copied to clipboard

Root support

Open Uj947nXmRqV2nRaWshKtHzTvckUUpD opened this issue 4 years ago • 3 comments

Good to have feature

@fusionneur You mean allow access to root folders in file explorer?

massivemadness avatar Dec 25 '20 11:12 massivemadness

Very Good Function.

ghost avatar Aug 13 '22 20:08 ghost

9948091dfb59f0585f6d961a689f758846a331c9

massivemadness avatar Sep 08 '22 18:09 massivemadness

How can I enable root mode? I switched from 'local storage' to 'root directory', but magisk 'grant root' popup does not appear. In the left pane I get "No result" under "/" folder.

@fusionneur the last time when I used root was in 2014 on Samsung Galaxy S3, and if I remember correctly, shouldn't you just grant access in your "root manager app" like SuperSU? 🤔

massivemadness avatar Oct 02 '22 10:10 massivemadness

@fusionneur the last time when I used root was in 2014 on Samsung Galaxy S3, and if I remember correctly, shouldn't you just grant access in your "root manager app" like SuperSU? 🤔

you might've missed quite a bit in 8 years xD most commonly used rooting method is through magisk nowadays. Squircle does not appear in the superuser list. It is deffinitely a bug in the implementation

Got it 😄 I'll fix it in the next release

massivemadness avatar Oct 02 '22 19:10 massivemadness

@fusionneur Hi, could you please test this build? I just rooted my device with magisk and it seems to work, but I need someone with more experience :)

massivemadness avatar Oct 04 '22 16:10 massivemadness

Hi ! Great work. On this build, magisk popup is properly triggered and I am able to browse system files.

Ok, but zip4j will not work properly with root files, so I disabled compress/extract actions

massivemadness avatar Oct 05 '22 07:10 massivemadness

what kind of problems does zip4j, could it be related to https://github.com/srikanth-lingala/zip4j/issues/462 for which a fix was released recently? In any case, in my opinion a code editor should do what a code editor is supposed to do: edit code It is the file or archive manager that should do the compressing/extracting. Taking visual studio code for example, you can't extract zips with it. Alternatively, you could leave the feature disabled only for root mode.

It's mostly because of the SuFile implementation, there's a new method newOutputStream which I have to use instead of normal java.io.FileOutputStream

massivemadness avatar Oct 05 '22 08:10 massivemadness

https://github.com/massivemadness/Squircle-CE/releases/tag/2022.2.1

massivemadness avatar Oct 05 '22 14:10 massivemadness