Microsoft-Activation-Scripts icon indicating copy to clipboard operation
Microsoft-Activation-Scripts copied to clipboard

"Check Windows updates and store app blockers" always returns [FOUND]

Open TheMMC opened this issue 9 months ago • 1 comments

Line 425 to 427 in HWID_Activation.cmd: reg query HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Policies\Explorer /v SettingsPageVisibility %nul2% | find /i "windowsupdate" %nul% && set updatesblock=1 reg query HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\WindowsUpdateSysprepInProgress %nul% && set updatesblock=1 reg query HKLM\SOFTWARE\Policies\Microsoft\Windows\WindowsUpdate /s %nul2% | findstr /i "NoAutoUpdate DisableWindowsUpdateAccess" %nul% && set updatesblock=1

This just checks the existence of the registry keys, not their value. I have NoAutoUpdate=0 in my registy, but the batch returns "Checking Update Blocker In Registry [Found]" just because I got that registy key at all.

/edit line 436: DisableStoreApps set to 0 is properly checked for the value. Just use the same logic for DisableWindowsUpdateAccess and NoAutoUpdate, please :)

TheMMC avatar May 28 '24 06:05 TheMMC