massa icon indicating copy to clipboard operation
massa copied to clipboard

Protocol : update_ask_operation and Peer disconnection

Open modship opened this issue 1 year ago • 2 comments

The update_ask_operation function in retrieval.rs of operation_handler poorly handles peer disconnections.

⚠️ Sometimes spamming Failed to send AskForOperations message to peer: {} when a peer is disconnected.

on_operations_announcements_received is called with a disconnected peerId

modship avatar Jul 13 '23 09:07 modship

https://github.com/massalabs/massa/pull/4249

damip avatar Jul 13 '23 09:07 damip

TODO: check if the max capacity of op_batch_buffer is reached

damip avatar Jul 13 '23 09:07 damip