massa
massa copied to clipboard
implements get_best_parents method
- [ ] document all added functions
- [X] try in sandbox /simulation/labnet
- [ ] unit tests on the added/changed features
- [ ] make tests compile
- [ ] make tests pass
- [X] add logs allowing easy debugging in case the changes caused problems
- [X] if the API has changed, update the API specification
#3419
@aoudiamoncef
I should update openrpc.json file manually ?
@aoudiamoncef
I should update openrpc.json file manually ?
Yes
Hi @modship @Leo-Besancon
I continued the work on this PR by removing pagination from get_next_block_best_parents
and reusing the code in get_largest_stakers
In this PR, we are adding an evolutive way to do request parameters and pagination. We'll try to add this to testnet19 and collect feedbacks from our consumers. take a look at https://github.com/massalabs/massa/issues/3485
I'll update the Postman collection with this new experimental methods.
@Leo-Besancon,
I added a default offset limit on get_largest_stakers
to return the first 50 stakers.
.
IMHO, this is fine for an experimental feature, we'll collect the feedbacks in testnet19 and improve things.
@modship can you rebase this on the latest version of testnet_20 ? the CI has been fixed and you will be able to merge it.