massa icon indicating copy to clipboard operation
massa copied to clipboard

implements get_best_parents method

Open modship opened this issue 2 years ago • 2 comments

  • [ ] document all added functions
  • [X] try in sandbox /simulation/labnet
  • [ ] unit tests on the added/changed features
    • [ ] make tests compile
    • [ ] make tests pass
  • [X] add logs allowing easy debugging in case the changes caused problems
  • [X] if the API has changed, update the API specification

#3419

modship avatar Jan 20 '23 14:01 modship

@aoudiamoncef

I should update openrpc.json file manually ?

modship avatar Jan 20 '23 14:01 modship

@aoudiamoncef

I should update openrpc.json file manually ?

Yes

aoudiamoncef avatar Jan 20 '23 15:01 aoudiamoncef

Hi @modship @Leo-Besancon I continued the work on this PR by removing pagination from get_next_block_best_parents and reusing the code in get_largest_stakers

In this PR, we are adding an evolutive way to do request parameters and pagination. We'll try to add this to testnet19 and collect feedbacks from our consumers. take a look at https://github.com/massalabs/massa/issues/3485

I'll update the Postman collection with this new experimental methods.

aoudiamoncef avatar Jan 31 '23 17:01 aoudiamoncef

@Leo-Besancon,

I added a default offset limit on get_largest_stakers to return the first 50 stakers. . IMHO, this is fine for an experimental feature, we'll collect the feedbacks in testnet19 and improve things.

aoudiamoncef avatar Feb 01 '23 13:02 aoudiamoncef

@modship can you rebase this on the latest version of testnet_20 ? the CI has been fixed and you will be able to merge it.

AurelienFT avatar Feb 03 '23 08:02 AurelienFT