massa
massa copied to clipboard
massalabs
Keep old testnet final ledger.
- [x] document all added functions
- [ ] try in sandbox /simulation/labnet
- [ ] unit tests on the added/changed features
- [ ] make tests compile
- [ ] make tests pass
- [x] add logs allowing easy debugging in case the changes caused problems
- [x] if the API has changed, update the API specification
Need to be tested, don't think it's a good thing to keep it for testnet 17.
That being said, most of the SCs from 16 won't work on 17
Yes I think we will implement it in testnet 18.
note: this has impacts on the deploy scripts for labnet/testnet
yes we need to remove the storage folder.
This PR is included in a more massive work about version and I think we should have some brainstorming before doing things like this. Moving it to TEST.19
This PR is tightly linked to the https://github.com/massalabs/massa/issues/3611 issue, so I think we should coordinate based on what we want to / can deliver for testnet_21, and what we want in the future.
In PR https://github.com/massalabs/massa/pull/3624, I made the assumption that we only keep the ledger if we want to restart from a snapshot, which is the case for only 1 node. (The other nodes will bootstrap the ledger from it as usual).
If we include the network restart capabilities in testnet_21, I would argue to keep the same approach: only have one node load the ledger with a CLI flag, and the other bootstrap from it. It's more expensive for the servers, but prevents syncing issues between them.
If we don't include the network restart capabilities, I think the current approach is fine for testnet_21. Maybe just add a --remove-ledger flag in sandbox mode to avoid having to delete it manually on every launch. (maybe even have it as the default?)
