massa icon indicating copy to clipboard operation
massa copied to clipboard

Massa does not show correct version tag

Open isezen opened this issue 2 years ago • 5 comments

Describe the bug Massa does not show correct version tag (see following commands). At the moment, version TEST.16.0.

$ massa-client --version
massa-client 0.1.0
$ massa-node --version
massa-node 0.1.0

Only way to get version tag is to run massa-client get_status -p password command, However, if the node did not connected to other boot sraps; the command gives the error below:

Error: check if your node is running: error trying to connect: tcp connect error: Connection refused (os error 111)

Expected behavior

$ massa-client --version
massa-client TEST.16.0
$ massa-node --version
massa-node TEST.16.0

Server Info:

  • OS: Linux Ubuntu Server
  • Version 22.04

isezen avatar Nov 03 '22 22:11 isezen

Hello, Thanks for the report

AurelienFT avatar Nov 04 '22 08:11 AurelienFT

This could be easily done with an RPC call, so we don't have to maintain it in client side.

aoudiamoncef avatar Nov 15 '22 15:11 aoudiamoncef

This could be easily done with an RPC call, so we don't have to maintain it in client side.

The --version is generated by cargo so your RPC call must modify the Cargo.toml I think it's better to have it in CD.

AurelienFT avatar Nov 15 '22 15:11 AurelienFT

This could be easily done with an RPC call, so we don't have to maintain it in client side.

The --version is generated by cargo so your RPC call must modify the Cargo.toml I think it's better to have it in CD.

I'm agree with you for binaries version. I'm sorry, I was talking about getting node version with an RPC call.

aoudiamoncef avatar Nov 15 '22 16:11 aoudiamoncef

Hi, Possible solution is to script that with cargo make : https://github.com/sagiegurari/cargo-make

It provide CARGO_MAKE_PROJECT_VERSION and CARGO_MAKE_CRATE_VERSION

modship avatar Nov 22 '22 10:11 modship

Now we have a task to set package versions of massa libraries. For the next testnet (TESTNET 23) the version number is 0.23.0

modship avatar Jun 01 '23 07:06 modship