massa icon indicating copy to clipboard operation
massa copied to clipboard

Read, check and resolve old unit tests

Open adrien-zinger opened this issue 2 years ago • 1 comments

We need to check one by one unit test that are ignored or commented. These tests have been commented after the release 14 because of a big change of the project architecture.

In the last pass of silenting tests I made the following list of where I add an ignore tag. Feel free to add commented tests into it. In addition, most of passing tests (excepted the test of serializations in the doc tests) need to be checked in order to be sure that it is still relevant.

NB: I also mute the fresh tests of pool and factory because one didn't passed anymore and the other had an infinite loop or a deadlock somewhere. We can first divide the reading and the fixes of the tests by files and then review in parallel with some mob programming sessions.

  • inter_cycle_batch_finalization

    • [x] test_inter_cycle_batch_finalization
  • scenario_block_creation

    • test_interleaving_block_creation_with_reception
  • scenarios106

    • test_unsorted_block_with_to_much_in_the_future
    • test_add_block_that_depends_on_invalid_block
    • test_too_many_blocks_in_the_future
    • test_dep_in_back_order_with_max_dependency_blocks
    • test_unsorted_block
  • scenarios91_1

    • test_gpi
    • test_old_stale
    • test_ti
  • scenarios91_2

    • test_double_staking
    • test_doubles
    • test_queueing
    • test_test_parents
  • scenarios_basic

    • test_block_not_processed_multiple_times
    • test_double_staking_does_not_propagate
    • test_old_stale_not_propagated_and_discarded
    • test_queuing
  • scenarios_endorsements

    • test_endorsement_check
  • scenarios_get_selection_draws

    • test_get_selection_draws_high_end_slot
  • scenarios_header_check

    • test_consensus_asks_for_block
    • test_consensus_does_not_ask_for_block
  • scenarios_note_attack_attempt

    • test_invalid_block_notified_as_attack_attempt
    • test_invalid_header_notified_as_attack_attempt
  • scenarios_parents

    • test_parent_in_the_future
    • test_parents
    • test_parents_in_incompatible_cliques
  • scenarios_pruning

    • test_pruning_of_awaiting_dependencies_blocks_with_discarded_dependency
    • test_pruning_of_awaiting_slot_blocks
    • test_pruning_of_discarded_blocks
  • scenarios_send_block

    • test_consensus_sends_block_to_peer_who_asked_for_it
    • test_consensus_block_not_found
  • scenarios_wishlist

    • test_wishlist_delta_with_empty_remove
    • test_wishlist_delta_remove

adrien-zinger avatar Sep 12 '22 06:09 adrien-zinger

Related issue https://github.com/massalabs/massa/issues/2893

AurelienFT avatar Sep 12 '22 07:09 AurelienFT