massa icon indicating copy to clipboard operation
massa copied to clipboard

Set real limits for deserialization maximum values

Open AurelienFT opened this issue 2 years ago • 2 comments

When deserializing, we need to make sure that everything has limits to avoid a message to break the memory of the node. We still have some variables that don't have a limit in mind :

  • [x] MAX_LEDGER_CHANGES_PER_BLOCK. We also need to apply this limit in block execution.
  • [ ] MAX_DATASTORE_ENTRY_COUNT. We also need to apply this limit in the code. Possible values : > 50000
  • [ ] Make the type of the constants standard. Possible : u64

AurelienFT avatar Aug 08 '22 14:08 AurelienFT

@damip can we take decisions on that ? I think that's nice if this is resolve before the tests.

AurelienFT avatar Sep 20 '23 12:09 AurelienFT

Now that we launched the mainnet reducing the maximum size of element in a datastore is a breaking change and should be done carefully.

AurelienFT avatar Mar 28 '24 13:03 AurelienFT