YoutubeDownloader
YoutubeDownloader copied to clipboard
Invalid file name
Hi, thanks for your nice package.
I have a problem with returned $filePath from onFinalized()
PATH_TO_FILE\...\videos\FC_Barcelona_vs_FC_Bayern_Munich_2015_(Champions_League_semi-final_Himno,Anthem ).3gp
can you see spaces after ')' ?
It seems )
is not usual parentheses )
as we know
I can't generate link to the file! browser return 404
error
original video: https://www.youtube.com/watch?v=sMq_A0ETURQ
Obviously this is related to pathSafeFilename function. There are many possibilities for this to fail, including some non-English characters, some emojis and spaces. PR is always welcome if you would. but there in Filename Sanitizing part of Readme, there is a way to change that function from outside of class. take a look at it.
oh sorry! I didn't see it. I will work on it and if I found a better solution, I will send a pull request.
I have another request about this package!
is there any way to change cache directory? I mean we can set video and cache directory as second and third parameters of __construct
many thanks.
Hi again
I implemented a custom sanitizing function for my own project.
in my function, I convert all non-english characters to the same character in english (if you set default language to fa
or ar
, conversion will be disabled)
feel free to change any part of my code, if you don't like it
any updates?
Could you test it again with the latest version? Now using UTF8 package.
I tested it with latest version (2.9.1)
but unfortunately file name generated with )
without any success
Please give me link to that video
https://www.youtube.com/watch?v=sMq_A0ETURQ
any updates?
![screen shot 1397-08-06 at 3 12 01 pm](https://user-images.githubusercontent.com/692335/47615423-d7468100-dac3-11e8-8904-82ce521991bd.png)
It is working in my PC
As you can see, it is downloading the file and no error happened
Yes I know. it downloaded for me too. but I can't generate download link for that in my website! because file name has unknown characters for browser and browser return 404!
It's not the parentheses, it's the ending white space. I'll look into it
On Sun, Oct 28, 2018, 9:47 PM Mostafa Zeinivand [email protected] wrote:
Yes I know. it downloaded for me too. but I can't generate download link for that in my website! because file name has unknown characters for browser and browser return 404!
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/masihyeganeh/YoutubeDownloader/issues/41#issuecomment-433728560, or mute the thread https://github.com/notifications/unsubscribe-auth/AAqQb3z-_a2no5yGGERbzh6MGqOYm4kjks5upfTXgaJpZM4T0uF7 .
![screen shot 1397-08-06 at 10 08 21 pm](https://user-images.githubusercontent.com/7619687/47620316-0a0d6b00-dafe-11e8-9c48-fc7b59b1d70c.png)