Don’t post-process the `MessageFormat` output in `__mf`
The output from the MessageFormat compiled function may contain arbitrary user-provided content, and cannot safely be re-parsed as an interval string, Mustache template, or printf format string.
- Fixes #544.
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
:x: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 97.99%. Comparing base (fcb0781) to head (0e7d0da).
| Files with missing lines | Patch % | Lines |
|---|---|---|
| i18n.js | 66.66% | 1 Missing :warning: |
| :exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality. |
Additional details and impacted files
@@ Coverage Diff @@
## master #546 +/- ##
==========================================
- Coverage 98.17% 97.99% -0.18%
==========================================
Files 2 2
Lines 548 549 +1
==========================================
Hits 538 538
- Misses 10 11 +1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
thanks again... :)
as the current implementation with enabled post-processing is in use for more than a decade, I would consider this a breaking change which requires a new release plus fallback opt-in to enable legacy behavior and docs.
There is at least one other PR that I wanted to merge before pushing new releases. So stay tuned.