Marcus Spiegel

Results 138 comments of Marcus Spiegel

hm concerning your #216: i18n returns from guessing before testing for headers when you configure any other options, like query param or cookie name. see https://github.com/mashpie/i18n-node/blob/master/i18n.js#L666 this effectively quits using...

I see, docs are mixed, tests refer to implementation https://github.com/mashpie/i18n-node/blob/master/test/i18n.api.js#L90 - but wouldn't it be nice to have choice? :)

I'm afraid i18n currently won't support such out-of-the-box - the idea of having pluggable storage-backends could face this in a far far future release. In the meantime you could manage...

ok, this one is hidden in tests... see https://github.com/mashpie/i18n-node/blob/master/test/i18n.api.js#L10 and https://github.com/mashpie/i18n-node/blob/master/test/i18n.api.js#L261 using register, will attach i18n's api to a dedicated object. To also use different directories for each object you...

as far as I know (and use cookieparser in my projects) there are no issues. Did you setup cookieparser middleware? - express4 example: https://gist.github.com/mashpie/08e5a0ee764f7b6b1355 - express3 example: https://gist.github.com/mashpie/5124626

looks correct... well, comparing https://github.com/mashpie/i18n-node/blob/master/i18n.js#L381 with your middleware keeps me thinking of a buggy cookieParser implementation in your setup. But this is just a quick guess

...again: we need more docs & examples (

I'm sure it will, as i18n is generally "framework agnostic". The examples provided show only a few of possible integrations. In general i18n could get attached to any object, like...