Christopher Nielsen

Results 351 comments of Christopher Nielsen

I just rebased against master, and plan to prioritize all of this over the next week or two. So please keep this open.

> > This is not correct. NDEBUG is part of the C standard with a very specific meaning. DEBUG is not. > > Correct. @szhorvat please submit a separate pull...

> > FWIW, defining NDEBUG or undefining it is just as unpredictable in terms of how various projects will react to it. > > This is not correct. `NDEBUG` is...

> > This is not correct. NDEBUG is part of the C standard with a very specific meaning. DEBUG is not. > > Correct. @szhorvat please submit a separate pull...

> No, I'll leave the PR to you @mascguy unless you all have an agreement that I should submit a separate change. Okay, I've added one more commit, which simplifies...

Oh, just noticed one other item that needs to be fixed: Flag `-DNDEBUG` needs to be added to the full suite of `configure.*flags` we handle, vis-a-vis manipulating the debug/optimization flags....

> @kencu @ryandesign Could you advise me if using `CC="${configure.cc} [get_canonical_archflags cc]"` is correct for a general case, considering it includes FAT builds as well? I'm not proficient enough with...

> @mascguy > UPD. Oh, this is 10.6 ppc-only. Why do we even care about building universal? It does not support `ppc64` (neither 10A190 nor Rosetta), and building for ppc+x86_64...

> I think we should set a deadline of September 1 or 2 and then close this. Generally I think we should have a policy of closing anything that someone...

Of note, since I was helping with this PR back many months ago, I'll take ownership of getting this completed.