btrfs-sxbackup icon indicating copy to clipboard operation
btrfs-sxbackup copied to clipboard

Add --container-subvolume-relpath flag for init

Open muir opened this issue 4 years ago • 5 comments

This is to allow the same source to be backed up to multiple destinations

muir avatar Feb 21 '21 07:02 muir

is it really necessary to be fully customizable path?

I would much prefer to support multi-destination via names, path convention and a more concise / intuitive option than --container-subvolume-relpath eg.

ref. https://github.com/masc3d/btrfs-sxbackup/issues/9

masc3d avatar Feb 22 '21 11:02 masc3d

how about

  • -n --name backup name
  • local subvol .sxbackup-$name

masc3d avatar Feb 22 '21 20:02 masc3d

how about

  • -n --name backup name
  • local subvol .sxbackup-$name

Would that also change the naming for the other destination backups? Currently they're things like sx-20210221-065715-utc but would that become $name-yyyymmdd-hhmmss-utc instead?

Would you like me to do that work? My python is quite rusty: this PR was the first I had touched it in 5 years.

muir avatar Feb 23 '21 06:02 muir

I presume the destination must remain dest/.btrfs-sxbackup because otherwise you would have to specify the name with every command.

muir avatar Feb 23 '21 06:02 muir

Would that also change the naming for the other destination backups? $name-yyyymmdd-hhmmss-utc instead?

each job should still have dedicated destination, so I don't believe it's necessary. why would it be beneficial to include name in snapshot volumes?

Would you like me to do that work? My python is quite rusty: this PR was the first I had touched it in 5 years.

same here xD I don't need this feature, so it's up to you "how far" you want to go. just want to make sure command line interface remains clean, as cleaning up later could be breaking change.

enhancing init as a first step will work just fine, no? this would be rather minimal change to your PR.

masc3d avatar Feb 23 '21 11:02 masc3d