Masayuki Ishikawa

Results 53 comments of Masayuki Ishikawa

>@masayuki2009 it's hard to split the style change from the patch now. could you have method to retrieve the old revision from github? I think you can always retrieve the...

@xiaoxiang781216 As for style changes, I think you can create another PR, and after the PR is merged then rebase this PR. The result would be much simpler to review.

`sim:usrsocktest` with `CONFIG_DEBUG_ASSERTIONS=y` failed. ``` up_assert: Assertion failed at file:/mnt/m2ssd/opensource/github_anjiahao1/nuttx/include/nuttx/mutex.h line: 489 task: nsh_main ```

@xiaoxiang781216 >But, the initial version doesn't exist in my local git anymore. If I can't retrieve the initial/early version of this patch from github, it's very hard and error prone...

>sim:usrsocktest with CONFIG_DEBUG_ASSERTIONS=y failed. Same as `spresense:wifi_smp` with `CONFIG_DEBUG_ASSERTIONS=y` ``` AEG [ 0.440000] [CPU1] up_assert: Assertion failed CPU1 at file:/mnt/m2ssd/opensource/github_anjiahao1/nuttx/include/nuttx/mutex.h line: 489 task: spresense_main [ 0.450000] [CPU1] arm_registerdump: R0: 00000000...

>@masayuki2009 @pkarashchenko the style change is revert, please review again. @xiaoxiang781216 Thanks for your efforts and updates. It seems much easier to check the differences but I still have some...

>nxmutex_t is initialized directly at the variables(g_i2cxdev) definition, not in cxd56_i2cbus_initialize, and then the code can be protected by mutex_t self, so it's redundancy to use the critical section here....

>@masayuki2009 ok, the change split into two patch, please review again. @xiaoxiang781216 Thanks for the changes. As far as I can see, the first commit still contains several intentions. For...

@xiaoxiang781216 >As I said before, this patch want to distinguish sem_t usage which contain two part: I think the two parts are independent and if the commit is split into...

@takumiando Could you tell us your intention to use multiple RTCs?