seven_zip_ruby
seven_zip_ruby copied to clipboard
masamitsu-murase
Update rubies (#1)
- Resolve gcc 11 compatibility issue (https://github.com/masamitsu-murase/seven_zip_ruby/issues/36)
This issue happens when newer versions of gcc are used where default C++ standard is 17. There is an obvious mismatch in
7z code
if (!mftRec.Parse(ByteBuf, Header.SectorSizeLog, numSectorsInRec, NULL, 0))instead ofif (!mftRec.Parse(ByteBuf, Header.SectorSizeLog, numSectorsInRec, 0, NULL))Newer versions of 7z have this fix. I have made a backport. - Resolve Ruby 3.0.x/rubygems/bundler cache issue with 7z.so (p7zip converted to Ruby extension) The issue occurs with Ruby 3.0.x where 7z.so built outside of Ruby extension system was not considered for bundler cache
- Update GHA to run with new Rubies
- Use RSpec rake task
cc: @ronaldtse
This is a contribution from Metanorma (GitHub), a product of Ribose (GitHub).
(Thank you @maxirmx !)
@masamitsu-murase first of all, thank you for the fantastic gem! We (@riboseinc) have been using your seven_zip_ruby gem for our @metanorma and @fontist projects, and have a need to utilize the gem on the latest platforms and Ruby versions. I hope this PR of our contribution will be accepted. Thank you again!
This is a wonderful contribution! I was having the 7z.so issue as well and couldn't figure out the cause, but this branch solved it. Thank you.
@masamitsu-murase Any possibility of merging this or making the fork the official RubyGem version?
@masamitsu-murase Any possibility of merging this or making the fork the official RubyGem version?
@bkmgit
We have to publish a fork It is there: https://github.com/fontist/seven_zip_ruby https://rubygems.org/gems/seven-zip
Thank you