narray icon indicating copy to clipboard operation
narray copied to clipboard

narray 0.6.0.8 test fails

Open graaff opened this issue 12 years ago • 6 comments

With ruby 1.8.7 (2012-10-12 patchlevel 371) [x86_64-linux] I'm getting the following test failure:

..... the next will fail .....
$a.rot90                       
test/testreverse.rb:5:in `px': ./lib/narray_ext.rb:267:in `rot90': must be >= 2 dimensional array (RuntimeError)
    from (eval):1:in `px'
    from test/testreverse.rb:26:in `eval'
    from test/testreverse.rb:5:in `px'
    from test/testreverse.rb:26

graaff avatar May 09 '13 06:05 graaff

See the first line you copied.

masa16 avatar May 09 '13 06:05 masa16

So you are saying that the test suite should crash and have an exit code of 1? That makes it more difficult to use a CI system which always expects a clean run. You can't catch this exception and test it?

graaff avatar May 09 '13 07:05 graaff

This is a legacy test code before unit test became popular. Now it should be rewritten as Spec...

masa16 avatar May 09 '13 07:05 masa16

Aha, now I see what is going on. We already comment out the other similar tests for Gentoo's test phase, but this one has different wording. Ok, I'll handle this on the Gentoo side.

graaff avatar May 09 '13 07:05 graaff

Now that I'm past this problem I'm also seeing

test/testcomplex.rb:13:in `<main>': undefined method `im' for 0.25:Float (NoMethodError)

graaff avatar May 09 '13 07:05 graaff

Fixed. https://github.com/masa16/narray/commit/c56dc59527f0681dae7175b2fcab1fe534444f52 Thank you.

masa16 avatar May 09 '13 07:05 masa16