yojimbo icon indicating copy to clipboard operation
yojimbo copied to clipboard

Ability to specify matcher certificate & address

Open onehundredfeet opened this issue 3 years ago • 4 comments

Added the ability to specify a parameter for the certificate on the matcher logic. Added the ability to specify the address and port for the matcher.

Previously MBEDTLS3 #158

onehundredfeet avatar Jan 02 '22 00:01 onehundredfeet

Matcher is really not meant to be used in production code? It's just sort of an example...

gafferongames avatar Jan 02 '22 01:01 gafferongames

I would expect that most people write their own matcher, in a high level language, like golang, or node js in the backend...

gafferongames avatar Jan 02 '22 01:01 gafferongames

Understood, and I agree, however it's provided in the core yojimbo.cpp and not an example, so the code would be included (and likely stripped) in any production build.

I'd recommend splitting out the matcher functionality from the yojimbo.cpp if it's not expected to be production ready. However, it's the only way of using the 'connectToken' approach.

I have just been the matcher you provided as a way of proving out the connection token code path. I felt like the modifications in this pull request made the library more development friendly even if a final shippable version would likely be modified.

onehundredfeet avatar Jan 02 '22 08:01 onehundredfeet

OK I'll take a look at it

gafferongames avatar Jan 02 '22 17:01 gafferongames

Hi folks, I have actually removed the matcher entirely from the latest version of Yojimbo. It really doesn't belong with the core library, and it creates a dependency on mbedtls, which ultimately, forces the usage of a very large library on the user, who may not even want to use that for https!

gafferongames avatar Dec 24 '23 14:12 gafferongames