cvise icon indicating copy to clipboard operation
cvise copied to clipboard

remove-unused-outer-class is very restrictive on what it removes

Open aeubanks opened this issue 2 years ago • 1 comments

remove-unused-outer-class seems very restrictive on when it'll consider a class for removal. It won't consider classes with templates or a base class.

There are many times where the code doesn't compile if you remove a template param or a base class and doesn't pass the interestingness test, but the class isn't referenced otherwise and is fine to completely remove.

Any thoughts?

aeubanks avatar May 09 '23 17:05 aeubanks

Sure, please create a pull request where you would relax the restrictions and add new test-cases for the situations you are interested in.

Thanks.

marxin avatar May 10 '23 13:05 marxin