Martin Liška

Results 404 comments of Martin Liška

@artemyarulin @theduke can you take a look?

I made a brief analysis of what needs to be ported and the most problematic issues are connected to the following @Arshia001's change 9e189d0efcad6940903bd1e4c0f630fb94ca3e5b: https://github.com/wasmerio/wasmer/blob/04963f9e8aa1a94e9309c30e661223c26b59d36c/lib/cli/src/commands/journal/mount/fs.rs#L313-L335 Can you help us how...

Motivation for the crate bump are: - https://github.com/wasmerio/wasmer/security/dependabot/98 - https://github.com/wasmerio/wasmer/security/dependabot/64

> Nice work! Huge kudos on making this happen! Thank you! > target-lexicon used by wasmer don't have a default calling convention, so when we are doing cross-compilation, the code...

> Hey so I can confirm that all previous issues have been fixed(well, expect for unaligned loads / stores), thank you! Glad for that :rocket: > We've been testing more...

> Any chance we can change the implementation in the singlepass compiler to mirror the LLVM compiler? Sure, that's definitely something that could be implemented by a direct call to...

All right, I switched the implementation of the `Unreachable` for the Singlepass in the PR to use the direct call to `wasmer_vm_raise_trap`. > * `IntegerDivisionByZero` and likely `IntegerOverflow` are never...

> All right, I switched the implementation of the Unreachable for the Singlepass in the PR to use the direct call to wasmer_vm_raise_trap. @wakabat Just wanted to let you know...

@syrusakbary The PR is basically ready to be merged. However, it depends on a smaller tweaks to the CI when it comes to testing of `riscv64gc` target: #5817 #5815 #5809

The CI job `Run WAST tests on linux-riscv64` is green when running in CI under QEMU. Yay!