actions
actions copied to clipboard
marvinpinto
Add body override capability
Added a body tag to allow replacing the changelog with a custom body. This should resolve issue #19.
Thanks for taking the time to write this up! Could you also add tests to validate both sides of the optional body argument? (i.e. behaves correctly with a body provided, and also without a body provided) - look at the implemented tests for examples.
Will probably have to update the documentation as well (with examples).
I'll look through this more thoroughly in few days :+1:
Documentation complete, I leave it up to @marvinpinto to decide exactly how he wants to implement the example.
Could you squash all these commits into a single commit, and also use the commitlint guidelines? I am not sure why commitlint is not failing but it should. Also enable the checkbox to allow the repo maintainer to add commits (if you haven't already). I'll hopefully have a look at it this week and make any changes I need.
Thanks again!
Hmm, it looks like your squashing possibly brought in a whole bunch of other changes - to dependencies as well as the lock file? If you need to get your branch updated, you can rebase the changes onto your branch. But as is I will not merge this. I manage lock file and dependency updates myself.
I was asking you to only squash your changes down to a single commit so that I can take over and add my tweaks. This way you also get "credit" for it. Let me know if you're still up for doing this!
I removed your changes, squashed down to single commit, should be good now.
I think you might have made a mistake while squashing, all your code changes appear to be gone? (see the Files Changed section of this PR)
I think this should finally be it. I apologize for the time it has taken me, I am new to github, and didn't squash right the first time.
It looks like it is back to this state https://github.com/marvinpinto/actions/pull/124#issuecomment-821277533
As I said no worries if this is getting too much 👍🏾
I just made sure it was up to date with your master, is this not good? I also enjoy the experience this is giving me, so don't worry.
@marvinpinto @techno-sam Is there an update for this? I don't mind taking it over if needed.
I need someone to take this over, I can't figure it out anymore.
You were so close though ;)
Rollback your commit to changes:
git reset --soft HEAD~1
Check the status of the commit, i.e. what files you are adding to it:
git status
There'll be a lot of files you probably don't want to commit.
It says to unstage files you use git restore --staged <file>
So:
git restore --staged yarn.lock
git restore --staged .github/*
etc etc until what remains is only the files you edited.
Then git commit and give it a message again.
Now you have a repository full of unwanted changes for some reason.
To get rid of them use:
git reset --hard HEAD
Now we have a clean repo, so now we need to rebase it off the latest origin.
git fetch origin/master
git rebase origin/master
If you get a merge conflict, then resolve it following the instructions.
Then force push your repository up.
Hello, can someone push it please? For big rebases we having often issues with https://github.com/marvinpinto/actions/issues/255
Thank you! :+1:
I think this should now finally be good, big thanks to @russkel's comment.
Can this be merged, please?
We still seeing very often Error: API rate limit exceeded for installation ID .... since rebasing on linux-next generate very long changelog.