Marvin Kruse comments

Results 19 comments of


                                            Marvin Kruse

416 sc 138 implement immutability option for module deployments

Haven't reviewed it in detail yet, but do we not also need a way to retrieve the correct version from the new `TransparentInverterProxy` - so do we need to overwrite...

hash the roleId with orchestrator address in getOwnerRole and getManagerRole

Is this still relevant @0xNuggan?

Reevaluate Manager Role

Notes from call: We agree that it most likely should be removed as it is not really used for anything important. So we should revisit this and remove if there...

Expand IFundingManager.transferOrchestratorToken() to include token address

Is this still something that we want @0xNuggan? Or is this outdated?

Feat: PIM factories (restricted and immutable)

@fabianschu Overall looks good to me, one thing I just noticed though: we want to deploy the factories any time a testnet deployment goes through, potentially even with every deployment...

[SC-760] Create Workflow Deployment Scripts

@0xNuggan This is the last commit that Felix added to his Scripts PR, now based on `dev` with his script changes. You can either build upon it or scrap it...

Fix: Resolve Deployment Issues

@FHieser @fabianschu just tagging you for a review, this isn't "done" yet, as you can see in the warning, but the idea would be to get some feedback in general...

Fix: Resolve Deployment Issues

> I would like to see a proper E2E test on this. Yeah, I know! Will be done after we confirmed that the solution works 🤝

Fix: Resolve Deployment Issues

Note: Pushed the deterministic deployment fix separately, so this is only the external contract deployment stuff now. TODO: rename @marvinkruse