minihud icon indicating copy to clipboard operation
minihud copied to clipboard

[1.17.1-0.19.0] Crash when scrolling in the config GUI (H+C shortcut).

Open TelepathicGrunt opened this issue 2 years ago • 4 comments

I added MiniHUD into my development environment to try and debug some bounding box issues in structures. However, when I click H+C to open the GUI to toggle options, scrolling down crashes the game due to infinite recursion. The log is here: https://paste.ee/p/V1LyY

Let me know if you need more info

TelepathicGrunt avatar Oct 31 '21 19:10 TelepathicGrunt

That's weird, I wonder if it's a mapping version conflict. That malilib method should not be called from a vanilla method. Which Yarn mappings are you using? Maybe consider adding MiniHUD as source if you want it in a dev environment.

maruohon avatar Oct 31 '21 21:10 maruohon

I am actually using Mojmap mappings to make it easier to work between forge and fabric versions of my mod. Though it seems like minihub only support showing bounds of vanilla structures so I have to find a different mod to show piece boundaries (let me know if I am wrong about this. if I am, do you have a maven to get your source from? Jitpack is having issues with java 16 mods iirc)

TelepathicGrunt avatar Oct 31 '21 21:10 TelepathicGrunt

Okay, so I assume when the mod gets mapped to the unobfuscated mojmap names, there is a name collision with the vanilla Screen class in my text field class. Another reason why it was problematic that my older code extended the vanilla Screen class even in the widgets...

Currently MiniHUD is only set up to show vanilla structures, yes. I could make some changes at some point to make it viable to also show other modded structures.

I don't currently (regularly) push MiniHUD versions to my maven, as it hasn't been really requested or needed thus far. So only malilib is on my maven atm. And if you are using mojmap, then I guess it wouldn't really work using the source repo directly either, it would need to be remapped to mojmap somehow.

Was your initial intention just to get the structures working with your custom structures, or what were you trying to debug?

maruohon avatar Oct 31 '21 21:10 maruohon

Originally I was trying to debug my mansions that were using vanilla mansion code. In there, there was a bug where there can be a 3 block high hole. I needed to figure out which piece was suppose to be filling in that hole. https://bugs.mojang.com/browse/MC-110098

But I figured out that it was the small_wall nbt piece was asymmetrical and needed to be extended on one side and offset to fill in the hole properly image

mansion code is hell lol. but yeah i figured out my issue and dont need minihud now. But you can close this issue report then as if it is a remapping issue, that's on Loom's (i think) fault.

TelepathicGrunt avatar Oct 31 '21 21:10 TelepathicGrunt