itemscroller
itemscroller copied to clipboard
maruohon
What is the best way to continously mass craft honey blocks
Hi,
first of all, thanks for the awesome mod!
I recently upgraded to 1.15.2 and just build a massive honey farm. Now I used the mass craft feature to quickly craft my inventory into honey blocks. Unfortunately, I cannot do this continously (e.g. while being fed by droppers with new honey bottles) because the empty glass bottles stay in my inventory.
What is the best way to also drop out the empty glass bottles while crafting honey?
Many thanks and best regards!
I hadn't thought about that. I need to make it also drop all the returned items (left on the grid) from a craft, unless they are used in the recipe again (which I think doesn't happen in vanilla?).
I don't know of any receipt that would need the left grid results. Would be really awesome to have this feature! Let me know when there is a test version :)
There seems to be an extra problem with this... If your inventory is full, then vanilla seems to simply delete the returned items when you craft from input stacks larger than one.
So in other words when you for example craft Honey Blocks and have for example 4 honey bottles in the 4 crafting grid slots, if your inventory is full of honey bottles or honey blocks or whatever so that there is no place for the empty bottles, they will just get destroyed on all except the last craft where the grid becomes empty and the bottles can be returned to the grid.
OK, so it is important to not overflow your inventory. However, if itemscroller drops all empty glass bottles and honey blocks you can only have an issue if you instantly add more honey bottles then your inventory can handle, right?
Why are people abusing the bug tracker? This is meant for bug reports and anything else is disruptive to the development process because it obscures actual bugs. Join Discord for support.
@Boobies: This actually is a feature request. So I think its at the right place. Also, as long as the maintainer has no issue with this, I think it's fine. Adding such non-helpful comments seems like spam to me.
@maruohon: Can you give me a hint were I would have to start looking to implement this feature? Maybe I can send you a PR.
Personally I would prefer feature requests and any support requests to happen on Discord, and only actual bugs/issues to be posted on Github for the most part. But this isn't currently indicated anywhere and also the Discord invite links aren't really clearly added to all the projects, or the issue templates set up to indicate this, so basically currently I can't expect people who aren't already on the Discord server to know this.
Basically the main issue about "conversation-like" issues is that I have a Discord bot on two different servers, so the channels get quite spammy if there are lots of short messages sent.
As to the actual issue in hand here... Basically everything currently happens in the massive InventoryUtils class. I kind of want to try to rewrite things a little bit to be a bit cleaner and better maintainable. The actual fix for this is quite simple, the crafting grid just needs to be cleared after each craft, which already is done, but also in a case where the grid gets new non-recipe items after a craft, those items should be dropped, but only when the crafting is done in the massCraft mode.
@andreas-eberle If your still looking for a solution, take a look at this recent commit I made in my fork. The code can probably be improved, I just made this quickly since a member of my tech server needed it for his new honey farm.
https://github.com/Andrews54757/itemscroller-crafting-fix/commit/d12091da6e0d031a1b2ff54110dd7c3514cf5857
