M-A

Results 181 comments of M-A

It's always tricky for boards with multiple chipsets and specific firmware. For drivers where you effectively support a proprietary firmware (here it's https://github.com/adafruit/seesaw), I'd prefer to put them under a...

The guidance is don't copy. Design something new that strictly makes sense with periph's design.

while I can live with a broken linter, let's make sure the tests are not broken.

What is needed is a detection system, see https://github.com/periph/host/blob/main/rpi/rpi.go#L28 or https://github.com/periph/host/blob/main/beagle/black/black.go#L31 or https://github.com/periph/host/blob/main/orangepi/orangepi.go#L27 for example.

Do not use the rpi package if you are not on a raspberry pi. Instead, use GPIOs as they are named, using the gpioreg package; https://pkg.go.dev/periph.io/x/conn/v3/gpio/gpioreg#ByName

Thanks for the contribution! I left comments to help with the code but there's nothing critical.

Requires https://github.com/periph/conn/issues/32.

The problem with WaitForEdge() is that the implementation in https://github.com/periph/host/blob/main/sysfs/gpio.go is dependent on sysfs which is sensitive to timing issues from linux.

Dang, sorry to hear. I fear someone will have to do the migration. Since the driver is in host, not in conn, it's tracked at https://github.com/periph/host/issues/39.

Acknowledging the problem. This code needs a revamp, which I filed a separate issue for.